I do agree that the clip does exhibit a brighter picture than might be realistic. Life was difficult at this time and the picture portrays a high society life. The bouquet of orchids certainly was an extravagant expense. I have to say that the themes or approaches would be one of life is good and the musicals were a way of having some fun despite the struggles of everyday life at during this time. There's no doubt that there would have been more double entendre. Also the scene in Anna Held's dressing room would have had her in more of a state of undress as was in Broadway Melody
My all time favorite is Singing in the Rain. I have the movies poster framed and hanging on my house (it use to be in my office until I retired). Others I love are The Wizard of Oz (My! People come and go so quickly here!), On the Town (The Bronx is up and the Battery’s down. The people ride in a hole in the ground.), My Fair Lady (Move you’re bloomin’ a**), Mary Poppins (We better keep our eye on this one. She’s tricky.), White Christmas, and Yankee Doodle Dandy.