1. The clip does present a brighter, more care-free way of life than most people were experiencing during the Depression. Ziegeld tips the doorman (and the fact that there is a doorman) as if he doesn't have any money worries at all. Everyone in the audience is well-dressed and has the money to spend on a (frivolous) performance like this. Held has a personal lady's maid to assist her in her dressing room, and Ziegeld must have spend "thousand of francs" on the flowers. Who sends that many orchids in such a large elephant vase??
2. In other Depression-era musicals, I expect to see the competition between two men for the affection of one lady, probably disguised at first as a business competition. Even as in movies today, I expect the business relationship between the leading lady and the businessman to develop into a romantic interest. (I haven't seen this movie yet and am anxious to see how it turns out tomorrow night) I also expect to see a similar lack of concern for money in the musicals. If I had been around during the Depression and had the money to spend to see a movie, I really wouldn't want to spend it on a movie that reminded me of the hard times I was experiencing. I would want to go to the movies to escape those hard times for a little while.
3. If this movie had been made pre-code, I would expect her stage costume to have been much more revealing. I think Ziegeld would have already been in her dressing room when she arrived, and she would have changed out of her costume while he was there.